Add code format check as GitHub workflow. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karnkaul
force-pushed
the
karnage/format-check
branch
from
d048b2a to
27e2d56
Compare
swagween
approved these changes
Feb 2, 2024
| @@ -21,8 +21,12 @@ void Player::handle_wall_collision() { | |||
| auto const bounce_rect = bave::Rect<>::from_size(m_world_space - m_sprite.get_size(), glm::vec2{0.0f}); | |||
|
|
|||
| // if the sprite's position exceeds the play area, the corresponding velocity component needs to flip. | |||
| if (position.x < bounce_rect.top_left().x || position.x > bounce_rect.bottom_right().x) { m_physics.velocity.x *= -0.9f; } | |||
There was a problem hiding this comment.
Sometimes I really prefer this compact code style. Not sure if there's a way to allow for it in the formatting check, or perhaps you disagree with using the compact style, in which case, I'm curious to know why!
There was a problem hiding this comment.
Yeah me too, and it's already set to format that way! Unless the line would be too long, which here exceeds the 120 column limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
tools/format_code.shwhich runsclang-formaton all source files inDogTales/.Note: On Windows this will need to be run in git bash.
Also adds a GitHub workflow -
format-check, which runs the script above and fails if it results in modified files.The first commit demonstrates such a failure, the next commit fixes it.
Once this is merged into
main,format-checkwill be made a required check for PR merges.Note: click "Show all checks" on a PR to expand the list, if it is collapsed.